Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Consul UI to Node 18 (#19252) #19362

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Upgrade Consul UI to Node 18 (#19252) #19362

merged 2 commits into from
Oct 25, 2023

Conversation

WenInCode
Copy link
Contributor

Description

Manual backport of changes made in #19252 to release/1.17.x

The original backport looks to have gotten caught up in the backport backlog when they were disabled during the cutting of the ga branch and subsequently removed from the merged code in this PR: #19350

Manually backporting it into the release/1.17.x branch

Testing & Reproduction steps

Links

Original PR
Failed backport

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@chris-hut @ellacai
Upgrade Consul UI to Node 18 (#19252)
acf1df2 
* Upgrading node to node 18

* Ensure we're on latest version of yarn as well

* add comma to make frontend tests run

* Use Node 18 Alpine image in UI build dockerfile

* delete package-lock.json

---------

Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com>
Co-authored-by: Ella Cai <ella.y.cai@gmail.com>
Co-authored-by: Ella Cai <ella@hashicorp.com>
@WenInCode WenInCode added the theme/ui Anything related to the UI label Oct 25, 2023
@WenInCode WenInCode requested a review from a team October 25, 2023 13:46
@WenInCode WenInCode requested a review from a team as a code owner October 25, 2023 13:46
@WenInCode WenInCode requested review from modrake and emilymianeil and removed request for a team October 25, 2023 13:46
@github-actions github-actions bot added type/ci Relating to continuous integration (CI) tooling for testing or releases theme/contributing Additions and enhancements to community contributing materials labels Oct 25, 2023
@WenInCode
Copy link
Contributor Author

There is no nightly test 1.17 on the release/1.17 branch, I'm assuming the 1.13 branch got renamed to it so I removed those changes here.

@WenInCode WenInCode merged commit dbac27d into release/1.17.x Oct 25, 2023
90 of 92 checks passed
@WenInCode WenInCode deleted the backport/ui/CC-6137-to-release-1.17.x branch October 25, 2023 16:21
@philrenaud philrenaud mentioned this pull request Jul 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-hut chris-hut chris-hut approved these changes

@modrake modrake Awaiting requested review from modrake

@emilymianeil emilymianeil Awaiting requested review from emilymianeil

Assignees
No one assigned
Labels
pr/no-backport theme/contributing Additions and enhancements to community contributing materials theme/ui Anything related to the UI type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WenInCode @chris-hut